Option to Directly Specify taskDefinitionArn as an Input Parameter#524
Option to Directly Specify taskDefinitionArn as an Input Parameter#524miltonhit wants to merge 3 commits intoaws-actions:masterfrom
Conversation
…ion input parameter.
…irectly pass the ARN.
|
I was looking for this option, is it something that has been considered for merge? |
|
It would be great to have that feature. |
|
@fabn @crissdev I've done this change in a fork. Repo: https://github.com/miltonhit/amazon-ecs-deploy-task-definition |
|
thanks @miltonhit. I'm currently using some of that in my fork. |
|
Hi @miltonhit, Thank you for your Patience. Apologies for the delay. We appreciate your contribution to the repository and will be working to review the changes in the Pull Request. In the meantime please ensure that below steps, if not already completed, are taken care of in your Pull Request:
|
| const taskDefContents = maintainValidObjects(removeIgnoredAttributes(cleanNullKeys(yaml.parse(fileContents)))); | ||
| let registerResponse; | ||
| try { | ||
| registerResponse = await ecs.registerTaskDefinition(taskDefContents).promise(); |
There was a problem hiding this comment.
This PR needs to be updated to use AWS SDK for JavaScript (v3)
Refer: #529
There was a problem hiding this comment.
| registerResponse = await ecs.registerTaskDefinition(taskDefContents).promise(); | |
| registerResponse = await ecs.registerTaskDefinition(taskDefContents); |
|
Is there a way we can get this merged? This is support I'd love to see. If @miltonhit isn't responsive here should I open a new PR which resolves the conflicts? Edit: I raised a PR here which implements this in a way which is compatible with the v3 API. We've started using this internally so I'm pretty confident it works sufficiently. |
|
Thanks for your PR @LukeSheard! Appreciate the contribution. Taking a look |
|
Hey @s3cube any update on being able to get my PR merged in? 🤞 |
|
Is this close to being merged? It would be great to get this feature. |
|
@omkhegde @amazreech @kg-aws @gzub-resonate (sorry for direct tag) is this something we could please merge 🤞 (have been open for almost two years now) |
Description of changes:
Added conditional logic to support both direct task definition ARN or task definition files in ECS task registration.
With this enhancement, you will be able to create or register your task definition using external tools like CloudFormation, Amazon CDK, or the Serverless Framework. Once registered, simply submit it here for streamlined deployment and await a successful response.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.